Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix distributed transactions disruptions test with move table #16765

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix distributed transactions disruptions test with move table #16765

merged 1 commit into from
Sep 12, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Sep 12, 2024 •
edited by rohit-nayak-ps
Loading

Description

Fuzzer test and Stress test were using common state which sometimes leave twopc_fuzzer_update table on 2 keyspaces.
It causes an ambiguous error on running move tables disruption on the stress test after fuzz test have completed.

The PR split these into two different packages so that they do not interact with each other.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal
move fuzz test to different package due to shared state between fuzz …
a8e8fee 
…and stress in twopc tests

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 12, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 12, 2024
@harshit-gangal harshit-gangal added Component: Query Serving Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 12, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 12, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (d9e59b6) to head (a8e8fee).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16765      +/-   ##
==========================================
- Coverage   68.94%   68.93%   -0.01%     
==========================================
  Files        1565     1565              
  Lines      201764   201764              
==========================================
- Hits       139112   139095      -17     
- Misses      62652    62669      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shlomi-noach
shlomi-noach approved these changes Sep 12, 2024
View reviewed changes
go/test/endtoend/transaction/twopc/utils/utils.go

// WaitForResults waits for the results of the query to be as expected.
func WaitForResults(t *testing.T, vtParams *mysql.ConnParams, query string, resultExpected string, waitTime time.Duration) {
timeout := time.After(waitTime)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference to always use context.WithTimeout and then cehck for <- ctx.Done(). This would also do the right thing for mysqlConnec(ctx, ...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this PR, I will leave it as-is. As it is concerned with resolving flaky test issues.

@harshit-gangal harshit-gangal merged commit da4b81d into vitessio:main Sep 12, 2024
109 checks passed
@harshit-gangal harshit-gangal deleted the fix-flaky-disruptions branch September 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Testing
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @shlomi-noach @rohit-nayak-ps